Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ui-build after building wheel #2500

Merged
merged 1 commit into from
Feb 3, 2023
Merged

Remove ui-build after building wheel #2500

merged 1 commit into from
Feb 3, 2023

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Feb 3, 2023

Closes #2491

Code Changes

  • Removes the ui-build directory after the wheel build is completed

Steps to Confirm

  • Run nox -s "fides_env(test)"
  • Navigate to http://localhost:8080 and log in
  • Navigate to any page that has a route after the /, such as http://localhost:8080/add-systems
  • Refresh the browser and verify the page loads with no error.

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@SteveDMurphy SteveDMurphy mentioned this pull request Feb 3, 2023
8 tasks
Copy link
Contributor

@SteveDMurphy SteveDMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the change works! Open question potentially around the removal of the volume mount going forward. I might try testing a built version as well...

@codecov
Copy link

codecov bot commented Feb 3, 2023

Codecov Report

Base: 88.45% // Head: 88.45% // No change to project coverage 👍

Coverage data is based on head (91e8f2c) compared to base (6f88689).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2500   +/-   ##
=======================================
  Coverage   88.45%   88.45%           
=======================================
  Files         327      327           
  Lines       15957    15957           
  Branches     4431     4431           
=======================================
  Hits        14115    14115           
  Misses       1688     1688           
  Partials      154      154           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sanders41 sanders41 marked this pull request as ready for review February 3, 2023 18:01
@sanders41 sanders41 merged commit 0f93ab3 into main Feb 3, 2023
@sanders41 sanders41 deleted the ps-catch-all-bug branch February 3, 2023 18:03
@allisonking allisonking mentioned this pull request Feb 3, 2023
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

browser refresh results in item not find
2 participants