-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default PII to hidden on page load #2388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this definitely works! I left a comment about a potential drawback, but if we don't want to deal with that now, we don't have to. mostly just wanted to raise it now so that we're aware of it
clients/admin-ui/src/features/privacy-requests/PrivacyRequestsContainer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for cleaning that up!! especially appreciate it since I know it wasn't a "necessary" fix and it did make the PR touch a lot more files. nice job! 👏
Codecov ReportBase: 88.55% // Head: 88.55% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2388 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 327 327
Lines 15714 15714
Branches 4348 4348
=======================================
Hits 13915 13915
Misses 1644 1644
Partials 155 155 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Closes #2286
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
The PII state wasn't being set properly for the PII toggle. Now it will correctly set it to false on page load.
Screen.Recording.2023-01-26.at.13.29.30.mov