Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default PII to hidden on page load #2388

Merged
merged 12 commits into from
Jan 31, 2023
Merged

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jan 26, 2023

Closes #2286

Code Changes

  • Default PII to hidden on pageload

Steps to Confirm

  • Run fides and create a privacy request.
  • Toggle the PII switch to reveal PII and navigate to the details page
  • confirm that the switch is set to hide PII and the PII is hidden
  • Toggle PII on and navigate back to the privacy requests table and confirm that revealing PII is turned off and PII is hidden

Pre-Merge Checklist

Description Of Changes

The PII state wasn't being set properly for the PII toggle. Now it will correctly set it to false on page load.

Screen.Recording.2023-01-26.at.13.29.30.mov

@TheAndrewJackson TheAndrewJackson changed the title Bugfix pii toggle fix Remember PII toggle state between pages Jan 26, 2023
@TheAndrewJackson TheAndrewJackson self-assigned this Jan 26, 2023
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review January 26, 2023 18:07
@TheAndrewJackson TheAndrewJackson changed the title Remember PII toggle state between pages Default PII to hidden on page load Jan 26, 2023
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this definitely works! I left a comment about a potential drawback, but if we don't want to deal with that now, we don't have to. mostly just wanted to raise it now so that we're aware of it

clients/admin-ui/src/features/common/PIIToggle.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@allisonking allisonking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for cleaning that up!! especially appreciate it since I know it wasn't a "necessary" fix and it did make the PR touch a lot more files. nice job! 👏

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 88.55% // Head: 88.55% // No change to project coverage 👍

Coverage data is based on head (2bca687) compared to base (502d689).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2388   +/-   ##
=======================================
  Coverage   88.55%   88.55%           
=======================================
  Files         327      327           
  Lines       15714    15714           
  Branches     4348     4348           
=======================================
  Hits        13915    13915           
  Misses       1644     1644           
  Partials      155      155           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheAndrewJackson TheAndrewJackson merged commit 5ccab10 into main Jan 31, 2023
@TheAndrewJackson TheAndrewJackson deleted the bugfix_pii_toggle_fix branch January 31, 2023 16:53
allisonking pushed a commit that referenced this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PII toggle state between request detail page and privacy request manager page are not maintained
2 participants