Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a check on the catchall path #2330

Merged
merged 4 commits into from
Jan 23, 2023
Merged

Add a check on the catchall path #2330

merged 4 commits into from
Jan 23, 2023

Conversation

allisonking
Copy link
Contributor

The catchall path should only serve paths found nested inside the UI directory

Closes https://github.com/ethyca/security-issues/issues/9

Code Changes

  • list your code changes here

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

Description Of Changes

Write some things here about the changes and any potential caveats

@allisonking
Add a check on the catchall path
fe14209 
The catchall path should only serve paths found nested inside the UI directory
@allisonking allisonking marked this pull request as ready for review January 23, 2023 16:40
seanpreston
seanpreston reviewed Jan 23, 2023
View reviewed changes
src/fides/api/main.py Outdated Show resolved Hide resolved
@allisonking allisonking mentioned this pull request Jan 23, 2023
Closed
TheAndrewJackson
TheAndrewJackson approved these changes Jan 23, 2023
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Awesome! Great work @allisonking

@allisonking
Copy link
Contributor Author

Code climate doesn't like the nested if. I think we could simplify it if we thought through #2334 more, but for now I'm going to merge

@allisonking allisonking merged commit 8d565f1 into main Jan 23, 2023
@allisonking allisonking deleted the aking/security-issues/9/check-for-ui-path branch January 23, 2023 19:04
SteveDMurphy pushed a commit that referenced this pull request Jan 24, 2023
@allisonking @SteveDMurphy
Add a check on the catchall path (#2330)
fa003e2
@SteveDMurphy SteveDMurphy mentioned this pull request Jan 24, 2023
Merged
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanpreston seanpreston seanpreston left review comments

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@allisonking @seanpreston @TheAndrewJackson