Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sample project resources for fides evaluate usage in fides deploy #2253

Merged
merged 2 commits into from
Jan 18, 2023

Conversation

NevilleS
Copy link
Contributor

@NevilleS NevilleS commented Jan 17, 2023

Code Changes

  • Fix reference to non-existent dataset demo_users_dataset
  • Update Postgres & Mongo systems to be specified as Databases
  • Update Postgres & Mongo system declarations to be more realistic uses 😄

Steps to Confirm

  • Run nox -s "build(sample)" to build sample project files
  • Run pip install ~/git/fides && fides deploy up --no-pull in a venv to install locally
  • Try fides pull -a .fides/sample_resources.yml to pull all resources
  • Try fides evaluate --dry to see if policy evaluation passes by default
  • Modify the cookie_house_mongo declaration to be used for advertising.third_party and see if policy evaluation fails

Pre-Merge Checklist

Description Of Changes

This modifies the Cookie House YAML declarations to be more accurate and consistent, removes the reference to the missing demo_users_dataset, and makes it easier to quickly experiment with Fides policies!

Goal here is just to have a built-in demo of the CI policies baked into the Cookie House sample project too - we're close, but since the declarations aren't quite internally consistent it doesn't serve as a useful demo of those features yet.

This modifies the Cookie House YAML declarations to be more accurate and
consistent, removes the reference to the missing demo_users_dataset, and
makes it easier to quickly experiment with Fides policies!
@ThomasLaPiana ThomasLaPiana self-requested a review January 18, 2023 03:22
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed the failure, nice change!

@NevilleS NevilleS merged commit 7f35b8f into main Jan 18, 2023
@NevilleS NevilleS deleted the ns-update-sample-project-resources branch January 18, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants