Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1873 saas connector friendbuy nextgen #2085

Merged
merged 11 commits into from
Jan 12, 2023
Merged

1873 saas connector friendbuy nextgen #2085

merged 11 commits into from
Jan 12, 2023

Conversation

ghost
Copy link

@ghost ghost commented Dec 19, 2022

Purpose

  • Purpose of this PR is to add Friendbuy Nextgen connector access and erasure endpoints

Changes

  • Added config for Friendbuy Nextgen Access and Erasure Endpoints
  • Added related dataset and configuration
  • Added associated tests to validate above functionality
  • Added custom request for delete endpoint

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1873

@ghost ghost requested a review from galvana December 19, 2022 18:21
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023 •
edited
Loading

Code Climate has analyzed commit 3668dd7 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

adamsachs
adamsachs approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - simple and clean!

just a nit on a docstring that i think you forgot to update :)

adamsachs
adamsachs approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - simple and clean!

just a nit on a docstring that i think you forgot to update :)

adamsachs
adamsachs approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - simple and clean!

just a nit on a docstring that i think you forgot to update :)

@adamsachs
Copy link
Contributor

^i liked this PR so much i approved it thrice

@galvana galvana merged commit cbb410a into main Jan 12, 2023
@galvana galvana deleted the 1873-saas-connector-friendbuy-nextgen branch January 12, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana Awaiting requested review from galvana

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FriendBuy NextGen
2 participants
@adamsachs @galvana