remove backend for ratelimiter

.github/workflows/cli_checks.yml

@@ -19,7 +19,7 @@ env:
 jobs:
   Test-Envs:
     runs-on: ubuntu-latest
-    timeout-minutes: 15
+    timeout-minutes: 25
     steps:
       - name: Checkout
         uses: actions/checkout@v3

CHANGELOG.md

@@ -34,6 +34,7 @@ The types of changes are:
 
 * Timing issues with bulk DSR reprocessing, specifically when analytics are enabled [#2015](https://github.com/ethyca/fides/pull/2015)
 * Error caused by running erasure requests with disabled connectors [#2045](https://github.com/ethyca/fides/pull/2045)
+* Changes the SlowAPI ratelimiter's backend to use memory instead of Redis [#2054](https://github.com/ethyca/fides/pull/2058)
 
 ## [2.2.2](https://github.com/ethyca/fides/compare/2.2.1...2.2.2)
 

src/fides/api/main.py

@@ -65,7 +65,6 @@
     key_prefix=CONFIG.security.rate_limit_prefix,
     key_func=get_remote_address,
     retry_after="http-date",
-    storage_uri=CONFIG.redis.connection_url,
 )
 app.add_exception_handler(RateLimitExceeded, _rate_limit_exceeded_handler)
 app.add_middleware(SlowAPIMiddleware)

tests/ops/api/test_ratelimit.py

@@ -24,7 +24,6 @@ def api_client_for_rate_limiting() -> Generator:
         key_prefix=CONFIG.security.rate_limit_prefix,
         key_func=get_remote_address,
         retry_after="http-date",
-        storage_uri=CONFIG.redis.connection_url,
     )
     with TestClient(app) as c:
         yield c
@@ -34,11 +33,10 @@ def api_client_for_rate_limiting() -> Generator:
             key_prefix=CONFIG.security.rate_limit_prefix,
             key_func=get_remote_address,
             retry_after="http-date",
-            storage_uri=CONFIG.redis.connection_url,
         )
 
 
-def test_requests_rate_limited(api_client_for_rate_limiting, cache):
+def test_requests_rate_limited(api_client_for_rate_limiting):
     """
     Asserts that incremental HTTP requests above the ratelimit threshold are
     rebuffed from the API with a 429 response.
@@ -54,14 +52,6 @@ def test_requests_rate_limited(api_client_for_rate_limiting, cache):
     response = api_client_for_rate_limiting.get(HEALTH)
     assert response.status_code == 429
 
-    ratelimiter_cache_keys = [key for key in cache.keys() if key.startswith("LIMITER/")]
-    for key in ratelimiter_cache_keys:
-        # Depending on what requests have been stored previously, the ratelimtier will
-        # store keys in the format `LIMITER/fides-/127.0.0.1//health/100/1/minute`
-        assert key.startswith(f"LIMITER/{CONFIG.security.rate_limit_prefix}")
-        # Reset the cache to not interere with any other tests
-        cache.delete(key)
-
 
 def test_rate_limit_validation():
     """Tests `SecuritySettings.validate_request_rate_limit`"""