Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove description column from classify systems table #1867

Merged
merged 2 commits into from
Nov 30, 2022
Merged

Remove description column from classify systems table #1867

merged 2 commits into from
Nov 30, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Nov 28, 2022 •
edited
Loading

Closes https://github.com/ethyca/fidesplus/issues/342

Code Changes

  • Removes the description column
  • Some styling updates now that there are only two columns

Steps to Confirm

  • Remove protected routes from _app.tsx and go to /classify-systems

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

image

@allisonking allisonking marked this pull request as ready for review November 28, 2022 20:34
TheAndrewJackson
TheAndrewJackson approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@allisonking allisonking merged commit 8050f87 into main Nov 30, 2022
@allisonking allisonking deleted the aking/fidesplus-342/hide-description-column branch November 30, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

@seanpreston seanpreston Awaiting requested review from seanpreston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@allisonking @TheAndrewJackson