Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescan UI #1844

Merged
merged 11 commits into from
Nov 29, 2022
Merged

Rescan UI #1844

merged 11 commits into from
Nov 29, 2022

Conversation

allisonking
Copy link
Contributor

@allisonking allisonking commented Nov 22, 2022

Closes #1827

Code Changes

  • Update typescript types with the new scan history and diff types
  • Update LoadDataFlowScanner so that it checks whether or not this is a rescan
  • If it is a rescan, only show the added systems (as given to us by the /scan/latest?diff=true endpoint)
  • Adds a state for systemsToClassify in redux so that we aren't reusing systemsToReview anymore
  • Updates nextjs to the latest, which has a fix for proxies timing out when they take over 30 seconds (the data flow scan API sometimes does. eventually, this will be replaced with an async flow, but for now, we have to live with it)
  • When we navigate away from the scan results page (the last step of the onboarding flow), add some logic to reset the config wizard state so it's easy to go back to and run a scan again
  • Cypress tests

Steps to Confirm

  • Comment out the protected routes in _app.tsx
  • Run make server in the fidesctl+ repo with scanning enabled
  • Clear your local db of scan history and systems that may already be around
$ psql postgresql://postgres:fidesctl@localhost:5432/fidesctl
psql (14.6 (Homebrew), server 12.12 (Debian 12.12-1.pgdg110+1))
Type "help" for help.

fidesctl=# DELETE FROM plus_system_scans ;
DELETE 4
fidesctl=# DELETE FROM ctl_systems;
DELETE 45
  • Now go through the add systems flow. Uncheck a few systems but register the rest.
  • Click on "Add Systems" again to be prompted to scan again
  • This time the scan should return the systems you didn't register earlier. Register them all
  • Click on "Add Systems" again to be prompted to scan again
  • This time the scan should find no new systems to register

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

(video edited to cut out some of the load screen times)

rescan2.mov

@allisonking allisonking marked this pull request as ready for review November 28, 2022 19:14
@allisonking allisonking merged commit ace2583 into main Nov 29, 2022
@allisonking allisonking deleted the aking/1827/rescan-ui branch November 29, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable rescanning using the scan history diff endpoint
2 participants