-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
privacy-center: Introduce fides-consent script package #1756
privacy-center: Introduce fides-consent script package #1756
Conversation
ecc1618
to
832d4ca
Compare
d6a8a2b
to
c641d47
Compare
832d4ca
to
145e29c
Compare
518f182
to
12895be
Compare
18c6fad
to
405a0ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the code looks good, but I get a 404 page doesn't exist when trying to access http://localhost:3000/fides-consent-demo.html
-- does a flag need to be active?
@LKCSmith - Running |
This change introduces a "packages" directory under the Privacy Center, which will house code that is built to work with the PC's consent options outside of the PC itself. The first such packages is the "tracking pixel script" which is a small script exposes the users consent choices through a window global.
This config cannot be supported by the browser script.
405a0ff
to
c98ada9
Compare
Closes #1395
Code Changes
fides-consent.js
, exposing the our cookie parsing logic in a browser script.Steps to Confirm
npm install
andnpm run cy:start
should put everything in place automaticallyPre-Merge Checklist
CHANGELOG.md
Description Of Changes
Actually writing the script was easy, but figuring out a good build + test flow was quite interesting. I used rollup, just like we have in fidesui. Next.js wouldn't let me use
<script>
tag with a static asset, so for testing I created a static HTML page that is simply served as-is. This is probably better for isolation anyway.