ui/taxonomy: CustomSelect isClearable - handle empty string selection #1712
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1504
Code Changes
isClearable
duringonChange
in forms.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
The single-select clearing functionality already existed, but we hadn't tried it anywhere. The only thing it was missing was assigning the value to a "cleared" value.
react-select
doesn't want to usenull
orundefined
for this state, which is reasonable since the native HTML way of doing it is to set an empty string (whenever the value would not match one of the option elements).This empty-string case then needs to be handled when transforming the form into an object to submit to the server.
I looked for other uses of
CustomSelect
where the value should be clearable, but they all seemed required to me. For example, submitting a null/undefined/empty-stringdata_qualifier
is not accepted by the server.