Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1388 recharge erasure #1709

Merged
merged 19 commits into from
Jan 12, 2023
Merged

1388 recharge erasure #1709

merged 19 commits into from
Jan 12, 2023

Conversation

sadaqatullah
Copy link
Contributor

@sadaqatullah sadaqatullah commented Nov 7, 2022 •
edited
Loading

Closes #1388 and #1101

Code Changes

  • Adds Access Endpoints
  • Adds Erasure Endpoints

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@sadaqatullah sadaqatullah linked an issue Nov 7, 2022 that may be closed by this pull request
Recharge - Erasure #1388
Closed
@sadaqatullah sadaqatullah changed the title 1388 recharge erasure 1388 recharge Access and Erasure Nov 14, 2022
@sadaqatullah sadaqatullah self-assigned this Nov 14, 2022
@sadaqatullah sadaqatullah linked an issue Nov 14, 2022 that may be closed by this pull request
Recharge - Access #1101
Closed
@sadaqatullah sadaqatullah force-pushed the 1388-recharge-erasure branch 2 times, most recently from 818f799 to fea0c0a Compare November 14, 2022 15:57
@sadaqatullah sadaqatullah requested a review from a team November 14, 2022 16:02
@sadaqatullah sadaqatullah force-pushed the 1388-recharge-erasure branch 2 times, most recently from 6906619 to cce8921 Compare November 17, 2022 14:22
@sadaqatullah sadaqatullah changed the title 1388 recharge Access and Erasure 1388 recharge erasure Nov 17, 2022
galvana
galvana reviewed Nov 28, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
sadaqatullah and others added 2 commits November 30, 2022 12:27
@sadaqatullah @galvana
Update CHANGELOG.md
6ac8847 
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
@sadaqatullah @galvana
Update data/saas/config/recharge_config.yml
8917b24 
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
@codeclimate
Copy link

codeclimate bot commented Jan 12, 2023 •
edited
Loading

Code Climate has analyzed commit 1027605 and detected 0 issues on this pull request.

View more on Code Climate.

@galvana galvana merged commit f0da063 into main Jan 12, 2023
@galvana galvana deleted the 1388-recharge-erasure branch January 12, 2023 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

@Zeeshan-Ethyca Zeeshan-Ethyca Awaiting requested review from Zeeshan-Ethyca

Assignees

@sadaqatullah sadaqatullah

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recharge - Erasure Recharge - Access
2 participants
@sadaqatullah @galvana