-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds config for notification service type, genericize concept of email to messaging #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eastandwestwind
force-pushed
the
1466-sms-config
branch
2 times, most recently
from
October 31, 2022 13:44
8b45aec
to
e194266
Compare
eastandwestwind
changed the title
Adds config for notification service type, starts work to genericize email dispatcher
Adds config for notification service type, genericize email dispatcher
Oct 31, 2022
eastandwestwind
changed the title
Adds config for notification service type, genericize email dispatcher
Adds config for notification service type, genericize concept of email to messaging
Oct 31, 2022
sanders41
reviewed
Nov 1, 2022
src/fides/api/ops/api/v1/endpoints/privacy_request_endpoints.py
Outdated
Show resolved
Hide resolved
src/fides/api/ops/api/v1/endpoints/privacy_request_endpoints.py
Outdated
Show resolved
Hide resolved
src/fides/api/ops/service/messaging/message_dispatch_service.py
Outdated
Show resolved
Hide resolved
src/fides/api/ops/service/messaging/message_dispatch_service.py
Outdated
Show resolved
Hide resolved
eastandwestwind
force-pushed
the
1466-sms-config
branch
from
November 1, 2022 15:49
d19c7b4
to
f7ea878
Compare
…re for twilio module
eastandwestwind
force-pushed
the
1466-sms-config
branch
from
November 3, 2022 14:44
c5ecbd6
to
51d57e2
Compare
sanders41
suggested changes
Nov 4, 2022
src/fides/api/ops/service/messaging/message_dispatch_service.py
Outdated
Show resolved
Hide resolved
sanders41
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes 1466
Code Changes
notification_service_type
for customer to specify notification service type (now includes Twilio SMS and email types)email
tomessaging
for endpoint paths, docs, API scopes, and celery queuetwilio
dependency torequirements.txt
twilio_text
,twilio_email
, andmailgun
.Follow-ups needed
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
Write some things here about the changes and any potential caveats