Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui/dataset: Only reset collection index on actual dataset update #1511

Merged
merged 3 commits into from
Oct 21, 2022
Merged

ui/dataset: Only reset collection index on actual dataset update #1511

merged 3 commits into from
Oct 21, 2022

Conversation

ssangervasi
Copy link
Contributor

@ssangervasi ssangervasi commented Oct 20, 2022 •
edited
Loading

Closes #1436

Code Changes

  • Test that replicates the collection switch.
  • Easy fix!

Steps to Confirm

  1. Edit a dataset with multiple collections
  2. Select a collection other than first.
  3. Edit and save any field.
  4. Result: The same collection should be shown, which shows the updated field.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated:
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

Description Of Changes

This is a case where multiple action dispatch is more error prone than having a single reducer that understands how the state should be updated.

@ssangervasi ssangervasi force-pushed the ssangervasi/fides-1436/table-jump branch from 2aa0f92 to c3170ae Compare October 20, 2022 21:38
@ssangervasi ssangervasi changed the title Ssangervasi/fides 1436/table jump ui/dataset: Only reset collection index on actual dataset update Oct 20, 2022
chriscalhoun1974
chriscalhoun1974 approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ssangervasi ssangervasi merged commit c0dfdfc into main Oct 21, 2022
@ssangervasi ssangervasi deleted the ssangervasi/fides-1436/table-jump branch October 21, 2022 00:35
@ssangervasi ssangervasi mentioned this pull request Oct 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriscalhoun1974 chriscalhoun1974 chriscalhoun1974 approved these changes

@LKCSmith LKCSmith Awaiting requested review from LKCSmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tables jump around when adding categories to fields.
2 participants
@ssangervasi @chriscalhoun1974