Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1076] ui/plus: Approve dataset classification button #1129

Merged
merged 9 commits into from
Sep 29, 2022
Merged

[1076] ui/plus: Approve dataset classification button #1129

merged 9 commits into from
Sep 29, 2022

Commits on Sep 29, 2022

  1. ui/dataset: Move breadcrumb above header

    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    9fe6d67 View commit details
    Browse the repository at this point in the history

  2. ui/dataset: Move classify status field to be per-dataset 

    Discussion:
https://github.com/ethyca/fidesctl-plus/pull/106#discussion_r980343600
    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    886c653 View commit details
    Browse the repository at this point in the history

  3. ui/dataset: Heading for classified dataset ready for review

    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    c34485c View commit details
    Browse the repository at this point in the history

  4. ui/cy: Negative test for non-plus dataset flow

    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    27b8ab0 View commit details
    Browse the repository at this point in the history

  5. ui/dataset: Show Approve Classification button for datasets that need… 

    … review

This commit does not include the mutation that will be triggered by the button.
    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    241bb24 View commit details
    Browse the repository at this point in the history

  6. ui/datasets: Helper for updating a dataset with top classification ca… 

    …tegories

This introduces immer as an explicit dependency, but it was already pulled in by RTK.
    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    f942103 View commit details
    Browse the repository at this point in the history

  7. ui/plus: Update dataset and classify status when approve button is cl… 

    …icked
    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    3dddd2d View commit details
    Browse the repository at this point in the history

  8. Update changelog

    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    9d2c863 View commit details
    Browse the repository at this point in the history

  9. ui/cy: Extract dataset intercepts to stubs

    @ssangervasi
    ssangervasi committed Sep 29, 2022
    Configuration menu
    Copy the full SHA
    2a25093 View commit details
    Browse the repository at this point in the history