Static check fixes

ethyca · Jul 27, 2023 · 7f72085 · 7f72085
1 parent be20507
commit 7f72085
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/clients/admin-ui/package.json b/clients/admin-ui/package.json
@@ -27,6 +27,7 @@
     "test:ci": "jest"
   },
   "dependencies": {
+    "@chakra-ui/icons": "1.1.7",
     "@emotion/react": "^11.10.6",
     "@emotion/styled": "^11.10.6",
     "@fidesui/components": "^0.7.1",
@@ -35,7 +36,6 @@
     "@monaco-editor/react": "^4.4.6",
     "@reduxjs/toolkit": "^1.9.3",
     "chakra-react-select": "^3.3.7",
-    "@chakra-ui/icons": "1.1.7",
     "csv-stringify": "^6.3.0",
     "cytoscape": "^3.23.0",
     "cytoscape-klay": "^3.1.4",
@@ -46,6 +46,7 @@
     "i18n-iso-countries": "^7.5.0",
     "immer": "^9.0.21",
     "js-yaml": "^4.1.0",
+    "lodash": "^4.17.21",
     "lodash.snakecase": "^4.1.1",
     "msw": "^1.2.1",
     "narrow-minded": "^1.2.1",

diff --git a/...src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx b/...src/features/datastore-connections/system_portal_config/forms/ConnectorParametersForm.tsx
@@ -25,6 +25,7 @@ import {
 import { useLazyGetDatastoreConnectionStatusQuery } from "datastore-connections/datastore-connection.slice";
 import DSRCustomizationModal from "datastore-connections/system_portal_config/forms/DSRCustomizationForm/DSRCustomizationModal";
 import { Field, FieldInputProps, Form, Formik, FormikProps } from "formik";
+import _ from "lodash";
 import React from "react";
 import { DatastoreConnectionStatus } from "src/features/datastore-connections/types";
 
@@ -40,7 +41,6 @@ import {
 import DeleteConnectionModal from "../DeleteConnectionModal";
 import { ConnectionConfigFormValues } from "../types";
 import { fillInDefaults } from "./helpers";
-import _ from "lodash";
 
 const FIDES_DATASET_REFERENCE = "#/definitions/FidesDatasetReference";
 
@@ -241,14 +241,14 @@ const ConnectorParametersForm: React.FC<ConnectorParametersFormProps> = ({
       // we currently only need to do this for Fides dataset references
       // to convert them from objects to dot-delimited strings
       if (secretsSchema?.properties) {
-        for (const [key, schema] of Object.entries(secretsSchema.properties)) {
+        Object.entries(secretsSchema.properties).forEach(([key, schema]) => {
           if (schema.allOf?.[0].$ref === FIDES_DATASET_REFERENCE) {
             const datasetReference = initialValues.secrets[key];
             initialValues.secrets[
               key
             ] = `${datasetReference.dataset}.${datasetReference.field}`;
           }
-        }
+        });
       }
 
       return initialValues;
@@ -272,8 +272,8 @@ const ConnectorParametersForm: React.FC<ConnectorParametersFormProps> = ({
           secretsSchema.properties[key].allOf?.[0].$ref ===
           FIDES_DATASET_REFERENCE
         ) {
-          const referencePath = updatedValues["secrets"][key].split(".");
-          updatedValues["secrets"][key] = {
+          const referencePath = updatedValues.secrets[key].split(".");
+          updatedValues.secrets[key] = {
             dataset: referencePath.shift(),
             field: referencePath.join("."),
             direction: "from",

diff --git a/clients/package-lock.json b/clients/package-lock.json
diff --git a/src/fides/api/api/v1/endpoints/system.py b/src/fides/api/api/v1/endpoints/system.py
@@ -1,6 +1,6 @@
 from typing import Dict, List, Optional
 
-from fastapi import Depends, Response, Security, HTTPException
+from fastapi import Depends, HTTPException, Response, Security
 from fastapi_pagination import Page, Params
 from fastapi_pagination.bases import AbstractPage
 from fastapi_pagination.ext.sqlalchemy import paginate