client/block: ensure BlockBodies requests get properly propagated #3673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
approved these changes
Sep 17, 2024
Has this been tested? |
|
deploying this right now to devnet3 |
|
confirmed the patch to be working in prsym<>ethereumjs node which was stalled, so we gtg 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
RequestBytesandRequestsBytes(plural!!) is a mistake hard-to-miss, maybe we should think of better naming for those types to avoid these kind of mistakes?)Will keep this at draft, will test (or someone else) later on devnet-3 if this fixes the issue where we report that clients are not sending us BlockBodies. So please only merge if this has been tested!