Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: migrate test files from json to js objects #3653

Merged
merged 36 commits into from
Sep 11, 2024
Merged

client: migrate test files from json to js objects #3653

merged 36 commits into from
Sep 11, 2024

Conversation

gabrocheleau
Copy link
Contributor

No description provided.

@gabrocheleau
common: test data
9602773
@gabrocheleau
devp2p: test data
5b716c8
@gabrocheleau
block: convert block test data
84d5264
@gabrocheleau
blockchain: convert blockchain test data
5db8f8f
@gabrocheleau
client: convert sim json configs
bcbd1bc
@gabrocheleau
block: adjust BeaconPayloadJSON type
10225a7
@gabrocheleau
block: adjust from beacon payload test
3a92009
@gabrocheleau
block: adjust from rpc test
7631a64
@gabrocheleau
block: adjust remaining blocks test data
ed6d438
@gabrocheleau
block: add chainconfig type
55e1486
@gabrocheleau
chore: merge with master
fbae7ae
@gabrocheleau
Merge branch 'master' into monorepo/typescript-test-files
092c05e
@gabrocheleau
block: adjust types and fix test
befc8ac
@gabrocheleau
Merge branch 'monorepo/typescript-test-files' of https://github.com/e…
1e98496 
…thereumjs/ethereumjs-monorepo into monorepo/typescript-test-files
@gabrocheleau
blockchain: adjust blockchain test data
b268563
@gabrocheleau
blockchain: adjust blockchain test data
efdd235
@gabrocheleau
client: adjust test type issues
360131b
@gabrocheleau
devp2p: fix test type issues
5c37723
@gabrocheleau
tx: fix test import
1379cd2
@gabrocheleau
devp2p: disable cspell for testdata
1a25fbe
@gabrocheleau
monorepo: fix spelling
85a3910
@gabrocheleau
common: remove unnecessary json parsing
83836bb
@gabrocheleau
vm: fix type issue in runTx
d44fdc7
@gabrocheleau
client: fix type issue in import
a24e543
@gabrocheleau
vm: fix import
80ef607
@gabrocheleau
util: add numeric string type
b9e9a5d
@gabrocheleau
block: use numeric string type
ac28a0d
@gabrocheleau
chore: fix merge conflicts
7ef44bd
@gabrocheleau
client: migrate test data from json to ts
f6e0246
@gabrocheleau
client: adjust tests
52d3c3e
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.02%. Comparing base (4470cc3) to head (564175b).
Report is 48 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 71.56% <ø> (-1.89%) ⬇️
client ?
common 91.47% <ø> (?)
devp2p 0.00% <ø> (?)
evm 69.07% <ø> (?)
genesis 0.00% <ø> (?)
statemanager 70.13% <ø> (?)
trie 54.51% <ø> (?)
tx ?
wallet ?

Flags with carried forward coverage won't be shown. Click here to find out more.

holgerd77
holgerd77 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@holgerd77 holgerd77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Massive!

I love things slowly getting better… and better … and better! 😁

Looks great to me! 🤩 Will merge.

@holgerd77 holgerd77 merged commit c85974a into master Sep 11, 2024
38 checks passed
@holgerd77 holgerd77 deleted the client/migrate-test-files branch September 11, 2024 07:48
@gabrocheleau gabrocheleau mentioned this pull request Sep 11, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holgerd77 holgerd77 holgerd77 approved these changes

Assignees
No one assigned
Labels
package: client PR state: needs review type: refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabrocheleau @holgerd77