-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting packages. #419
Formatting packages. #419
Conversation
Locally I get
|
Yes this is the problem with splitting things up, it's hard to keep track of what should be split up or stay together. Several .sty files need to be added or merged first, which I may do on Monday in a separate PR. Alternatively it is probably just simpler to stick with the odd convention of using two single quotes '' for opening quotes, so I might just remove these. (The downside is that editors will need to be familiar with this non-intuitive convention.) |
This issue is related: #366 |
PS I will probably make changes gradually so that I can spend more time on the JS sharding implementation. |
Restarted the build. |
Well the failing build still says csquotes.sty could not be found, so installing texlive-latex-extra didn't help. |
Not sure whether you have something else in mind other than adding the csquotes.sty (and maybe also others). |
@jamesray1 are you sure you've added |
@pirapira why does it need to be added to this PR when it has already been merged? That doesn't seem very functional. |
Anyway I added it, but it is still failing. |
@jamesray1 ProTip: when you rebase your branch on top of |
@pirapira, OK that sounds like you've tested that. But I'm confused, didn't I make this PR by editing the Paper.tex file in https://github.com/ethereum/yellowpaper, then adding another .travis.yml file, including with the extra How would rebasing this branch then help with csquote working? The |
The error before was because csquotes.sty was missing, but now it is:
I remember seeing a commit that fixed up a " to a ``, so that might explain it. |
My experience with git rebase hasn't been great. This is the commit that I mentioned: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
No description provided.