Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting packages. #419

Merged
merged 3 commits into from
Jan 25, 2018
Merged

Formatting packages. #419

merged 3 commits into from
Jan 25, 2018

Conversation

jamesray1
Copy link
Contributor

No description provided.

@pirapira
Copy link
Member

Locally I get


! Package csquotes Error: Unbalanced groups or invalid nesting.

See the csquotes package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.2222 \end{document}

@jamesray1
Copy link
Contributor Author

Yes this is the problem with splitting things up, it's hard to keep track of what should be split up or stay together. Several .sty files need to be added or merged first, which I may do on Monday in a separate PR. Alternatively it is probably just simpler to stick with the odd convention of using two single quotes '' for opening quotes, so I might just remove these. (The downside is that editors will need to be familiar with this non-intuitive convention.)

@jamesray1
Copy link
Contributor Author

This issue is related: #366

@jamesray1
Copy link
Contributor Author

PS I will probably make changes gradually so that I can spend more time on the JS sharding implementation.

@jamesray1
Copy link
Contributor Author

jamesray1 commented Jan 20, 2018

Requires #437. Uses #444 (merged).

@jamesray1 jamesray1 changed the title Formatting packages Formatting packages: Requires #437. Jan 20, 2018
@jamesray1 jamesray1 changed the title Formatting packages: Requires #437. Formatting packages. Jan 22, 2018
@jamesray1
Copy link
Contributor Author

jamesray1 commented Jan 22, 2018

@pirapira, the build ran 3 days ago and hasn't ran since #444 was merged. Please rerun the build. (I can't seem to do it.) According to here, csquotes is included in texlive-latex-extra.

@pirapira
Copy link
Member

Restarted the build.

@jamesray1
Copy link
Contributor Author

jamesray1 commented Jan 24, 2018

Well the failing build still says csquotes.sty could not be found, so installing texlive-latex-extra didn't help.

@jamesray1
Copy link
Contributor Author

Not sure whether you have something else in mind other than adding the csquotes.sty (and maybe also others).

@pirapira
Copy link
Member

@jamesray1 are you sure you've added texlive-latex-extra in this PR?

@jamesray1
Copy link
Contributor Author

@pirapira why does it need to be added to this PR when it has already been merged? That doesn't seem very functional.

@jamesray1
Copy link
Contributor Author

Anyway I added it, but it is still failing.

@pirapira
Copy link
Member

@jamesray1 ProTip: when you rebase your branch on top of ethereum/master, you get working csquote.

@jamesray1
Copy link
Contributor Author

jamesray1 commented Jan 25, 2018

@pirapira, OK that sounds like you've tested that.

But I'm confused, didn't I make this PR by editing the Paper.tex file in https://github.com/ethereum/yellowpaper, then adding another .travis.yml file, including with the extra sudo apt install texlive-latex-extra?

How would rebasing this branch then help with csquote working?

The jamesray1:patch-7 branch is currently 109 commits behind ethereum:master. So maybe that has something to do with it.

@jamesray1
Copy link
Contributor Author

The error before was because csquotes.sty was missing, but now it is:

! Package csquotes Error: Unbalanced groups or invalid nesting.
See the csquotes package documentation for explanation.
Type  H <return>  for immediate help.
 ...                                              
                                                  
l.2509 \end{document}

I remember seeing a commit that fixed up a " to a ``, so that might explain it.

@jamesray1
Copy link
Contributor Author

My experience with git rebase hasn't been great.

This is the commit that I mentioned:
7fc31a6

Copy link
Member

@pirapira pirapira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@pirapira pirapira merged commit 37aec90 into ethereum:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants