Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests for EIP-3860 #1125

Merged
merged 4 commits into from
Jan 6, 2023
Merged

Fix tests for EIP-3860 #1125

merged 4 commits into from
Jan 6, 2023

Conversation

gumb0
Copy link
Member

@gumb0 gumb0 commented Dec 27, 2022 •
edited
Loading

Implementation used ethereum/go-ethereum@805e691

Required error definition in retesteth

      "TR_InitCodeLimitExceeded" : "max initcode size exceeded",

@gumb0 gumb0 marked this pull request as ready for review December 27, 2022 14:23
@gumb0 gumb0 mentioned this pull request Dec 27, 2022
Merged
@winsvega
Copy link
Collaborator

winsvega commented Jan 2, 2023

@gumb0 ready?

@chfast
Copy link
Member

chfast commented Jan 3, 2023

Required error definition in retesteth

      "TR_InitCodeLimitExceeded" : "max initcode size exceeded",

Still needed?

@gumb0
Copy link
Member Author

gumb0 commented Jan 3, 2023

Required error definition in retesteth

      "TR_InitCodeLimitExceeded" : "max initcode size exceeded",

Still needed?

I think so, it is used in creationTxInitCodeSizeLimitFiller.yml

chfast
chfast approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@chfast chfast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from evmone side.

yperbasis added a commit to erigontech/erigon that referenced this pull request Jan 4, 2023
@yperbasis
ethereum/tests/pull/1125
53c244b
@yperbasis yperbasis mentioned this pull request Jan 4, 2023
Merged
@winsvega winsvega merged commit 8f90796 into ethereum:develop Jan 6, 2023
@gumb0 gumb0 deleted the eip-3860-fix branch January 6, 2023 14:50
yperbasis added a commit to erigontech/erigon that referenced this pull request Jan 6, 2023
@yperbasis
Amend EIP-3860 per EIPs/pull/6249 (#6502)
ac1428e 
See ethereum/EIPs#6249 and
ethereum/tests#1125
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chfast chfast chfast approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gumb0 @winsvega @chfast