Allow mapping arguments for public and external library functions. #5382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekpyron
force-pushed
the
libraryMappingPublic
branch
from
b60a486
to
a154a52
Compare
This comment has been minimized.
This comment has been minimized.
|
Sure, please also allow external functions and returning mappings. Don't forget changelog (which should be for 0.5.1, I would presume) and documentation. |
ekpyron
force-pushed
the
libraryMappingPublic
branch
from
63f5fbf
to
416aef9
Compare
ekpyron
commented
Nov 9, 2018
ekpyron
force-pushed
the
libraryMappingPublic
branch
from
416aef9
to
b8ac793
Compare
ekpyron
commented
Nov 9, 2018
ekpyron
force-pushed
the
libraryMappingPublic
branch
2 times, most recently
from
4882a17
to
e3034ef
Compare
ekpyron
force-pushed
the
libraryMappingPublic
branch
3 times, most recently
from
1972cd3
to
ee97963
Compare
chriseth
reviewed
Nov 14, 2018
ekpyron
force-pushed
the
libraryMappingPublic
branch
2 times, most recently
from
a1d5bdb
to
ae719f6
Compare
chriseth
previously requested changes
Nov 14, 2018
ekpyron
force-pushed
the
libraryMappingPublic
branch
from
ae719f6
to
76d9008
Compare
ekpyron
force-pushed
the
libraryMappingPublic
branch
from
76d9008
to
ab1ed61
Compare
chriseth
force-pushed
the
libraryMappingPublic
branch
2 times, most recently
from
27efcdf
to
53d1f39
Compare
axic
reviewed
Nov 22, 2018
| } | ||
| } | ||
| )"; | ||
| char const* sourceCode = R"( |
There was a problem hiding this comment.
Indentation seems to be off in tests, but that might be only on Github.
There was a problem hiding this comment.
I think this is just how github displays tabs.
|
Do we have syntax tests for: non-storage mapping in a library function? And all other valid/invalid combinations? |
|
I would say the tests are fine. |
leonardoalt
previously approved these changes
Nov 26, 2018
chriseth
force-pushed
the
libraryMappingPublic
branch
from
53d1f39
to
30e6f8d
Compare
|
Rebased. |
chriseth
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4635.
I may be missing something here, since the description in the issue predicts more changes to be necessary.
Also: the issue is restricted to public library functions - no reason to exclude external ones, though, is there?
Also: do we want to support returning mappings from public/external library functions as well? It seems like that would be more involved, but I could think of use cases for that as well (e.g. selecting a mapping from an argument that is a mapping to mappings).