eth/tracers/live: run supply tests off of generated artifacts #30451
+1,287
−174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1na
requested review from
lightclient,
gballet,
karalabe,
holiman and
rjl493456442
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the block test format used for consensus testing is also ideal for testing live tracers. I have taken our existing tests for the supply tracer and turned them into a filler binary + a dumb test runner that takes processes the json files. I believe this format can be re-used for other live tracers (with the exception of the
"except"field which would be different).The only thorn in my side is the filler. I've put it as an executable module right now in
eth/tracers/live/tests.