-
Notifications
You must be signed in to change notification settings - Fork 20k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal/ethapi: remove td field from block #30386
base: master
Are you sure you want to change the base?
Conversation
If we remove GetTd usage from ethstats then the method could be dropped from the EthAPIBackend completely. |
Why not? EDIT: Okay, let's keep it for a while, not sure whether ethstats will fail or not without the TD (although |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Looks like there are still some references to
|
Yep I fixed the ones in
Hm this one makes it so that when I do
I'd like to keep this out of this PR. |
Fixed last standing issue. PTAL |
Implements ethereum/execution-apis#570