Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geth/dumpconfig: fix undocumented helptext #26729

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Commits on Feb 19, 2023

  1. geth/dumpconfig: fix undocumented helptext

    This patch documentizes the 'saving into a file' option.
    As suggested in #16383, piping dumpconfig's stdout is imcompatible to the Windows powershell due to the UTF16LE encoding.
    To fix this, #18327 (428eabe) added an option to save dumpconfig in a file.
    However, users cannot be informed of this feature (saving into a file) without searching the relevant github issue or seeing source code.
    Thus, this patch fixes the aforementioned inconvenience by improving the description of the dumpconfig's help text.
    
    fixes: 428eabe
    
    Signed-off-by: Sungwoo Kim <git@sung-woo.kim>
    swkim101 committed Feb 19, 2023
    Configuration menu
    Copy the full SHA
    b01c6ed View commit details
    Browse the repository at this point in the history