cmd/geth, core/vm: setup vm settings and defaulted JIT disabled #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated: Sun Aug 9 00:06:50 UTC 2015 |
obscuren
added a commit
that referenced
this pull request
Aug 9, 2015
cmd/geth, core/vm: setup vm settings and defaulted JIT disabled
| DisableJit bool // Disable the JIT VM | ||
| ForceJit bool // Force the JIT, skip byte VM | ||
| MaxProgSize int // Max cache size for JIT Programs | ||
| DisableJit bool = true // Disable the JIT VM |
There was a problem hiding this comment.
We should consider changing the name away from the negative, i.g. EnableJit bool = false
Turning a flag on to disable a feature is conceptually strange
There was a problem hiding this comment.
Agreed. I'll have to submit a future PR for this. There are issues with the VM anyhow
maoueh
pushed a commit
to streamingfast/go-ethereum
that referenced
this pull request
Jul 21, 2023
…lter (ethereum#25186) (ethereum#1626) This PR adds a way to subscribe to the _full_ pending transactions, as opposed to just being notified about hashes. In use cases where client subscribes to newPendingTransactions and gets txhashes only to then request the actual transaction, the caller can now shortcut that flow and obtain the transactions directly. Co-authored-by: lx <92799281+brilliant-lx@users.noreply.github.com> Co-authored-by: lmittmann <lmittmann@users.noreply.github.com> Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.