Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "updated" with "modified" in Electra spec #3823

Merged
merged 4 commits into from
Jul 1, 2024

Conversation

jtraglia
Copy link
Member

This PR does the following:

  • Replace usages of "updated" with "modified" to be consistent with previous specs.
  • For modified functions, ensure there is a note about the changes.
    • I updated some of these notes to be consistent with other specs.
    • Some of these notes could be better 😅
  • Delete notes for new functions as we don't normally do this.
    • This was for process_withdrawal_request and process_deposit_request.
  • Replace "NOTE" with "Note" and "Electra:EIP-7251" with "Electra:EIP7251" for consistency.
  • Fix some excess blank lines & missing blank line nits.

@jtraglia jtraglia added general:proofread spelling, grammar, accuracy Electra labels Jun 28, 2024
Copy link
Collaborator

@mkalinin mkalinin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thanks!

@ralexstokes
Copy link
Member

@jtraglia I tried to save you some work by fixing a rebase in the web UI but it looks like I messed something up w/ the TOC

if you can plz fix im happy to merge this in, may just want to drop my commit and handle the conflicts that way

@jtraglia
Copy link
Member Author

jtraglia commented Jul 1, 2024

if you can plz fix im happy to merge this in, may just want to drop my commit and handle the conflicts that way

No worries! It was a simple fix. I think we should be good now.

@jtraglia jtraglia merged commit 77c371b into ethereum:dev Jul 1, 2024
26 checks passed
@jtraglia jtraglia deleted the replace-updated-with-modified branch July 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Electra general:proofread spelling, grammar, accuracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants