Switch the rest of the spec to MAX_EFFECTIVE_BALANCE_ELECTRA

[mkalinin]

This PR makes the rest of the places of the spec to use the new MAX_EFFECTIVE_BALANCE_ELECTRA preset instead of the old one, namely:

• initialize_beacon_state_from_eth1
• get_next_sync_committee_indices

One exception is compute_weak_subjectivity_period function which implements the strategy outlined in the WS research paper thus doesn’t need to be updated.

This change entails the following updates into the spec tests:

• Use MAX_EFFECTIVE_BALANCE_ELECTRA in the build_mock_validator for post-Electra forks
• Use MAX_EFFECTIVE_BALANCE_ELECTRA in test_initialize_beacon_state_some_small_balances when post-Electra
• Initialize validators with MAX_EFFECTIVE_BALANCE_ELECTRA balance for sync committee tests post-Electra affected by the change to get_next_sync_committee_indices

[hwwhww]

good catch @mkalinin ! 🙏

[hwwhww]

is it possible that, instead of adding new misc_balances_electra, we modify misc_balances by adding new if is_post_electra(spec) logic?

[hwwhww]

ditto. Is it possible that instead of adding new default_balances_electra, we modify default_balances by adding new if is_post_electra(spec) logic?

[mkalinin]

I was thinking about this approach but then decided to keep default balances as is because it makes a test run with 32 ETH balance validators which is also important for Electra. Ideally, we should run tests with MIN_ACTIVATION_BALANCE, MAX_EFFECTIVE_BALANCE_ELECTRA and something in between. It is probably better to handle this modification separately.

[hwwhww]

It's probably more just the naming problem; when I read default_balances_electra, I thought it is just "the default balances post-electra," but it is actually compatible with pre-electra. But I understand what you wanted to present.

[fradamt]

what about calling it max_balances instead? To me it explains pretty clearly what it does

[hwwhww]

It's probably more just the naming problem; when I read default_balances_electra, I thought it is just "the default balances post-electra," but it is actually compatible with pre-electra. But I understand what you wanted to present.

[hwwhww]

I fixed the broken test (aa65fd7). Ideally I should add a new test for Electra initialize_beacon_state_from_eth1, but since it's supposed to be removed (#3663), I didn't add that test case here.

[fradamt]

Generally lgtm

[fradamt]

Suggested change

	effective_balance=min(balance - balance % spec.EFFECTIVE_BALANCE_INCREMENT, max_effective_balace)
	effective_balance=min(balance - balance % spec.EFFECTIVE_BALANCE_INCREMENT, max_effective_balance)

[fradamt]

Suggested change

	max_effective_balace = spec.MAX_EFFECTIVE_BALANCE
	max_effective_balance = spec.MAX_EFFECTIVE_BALANCE

[fradamt]

Suggested change

	max_effective_balace = spec.MAX_EFFECTIVE_BALANCE_ELECTRA
	max_effective_balance = spec.MAX_EFFECTIVE_BALANCE_ELECTRA

[hwwhww]

ooops. will fix it after the release.

Thanks for the review!

[ralexstokes]

lgtm! +1 to hww's comments, but it looks like something was sorted