Pre-compute root of unity in fr-form #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This code has been around since 4844 and has been working nicely. I have a small preference for leaving old code sleep. If you like this PR, how about you add a small C test that shows that the new value you added is the same value from the uint64 array? Just to show that the new code and the old code (that will be removed) do the same thing. |
Okay yeah, I'll make that test. I do like this PR. |
|
@asn-d6 Okay this should be ready now. I'm glad we added these tests back, good suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
SCALE2_ROOT_OF_UNITYin uint64s-form withROOT_OF_UNITYin fr-form. I don't have a strong opinion about this, but I was hoping to simplify this. It should at least be moved outside of the header. I provide updated instructions (scripts) for generating this constant. Had to remove some tests forcompute_roots_of_unitythough.I would prefer a C function which uses
PRIMITIVE_ROOT_OF_UNITYand generates the root of unity with blst, but there isn't ablst_fr_powfunction and it seems quite difficult (maybe impossible) to do so ourselves.