Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profile & analyze #473

Merged
merged 4 commits into from
Aug 8, 2024
Merged

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Aug 6, 2024

So make profile and make analyze have been broken since the file split. This PR makes the following changes:

  • Run analyzer on each source file individually. Doesn't work when bundled together.
  • Fix some allocation nits in the tests. There were some potential leaks that the analyzer pointed out.
    • I'm using more stack variables now. They are big, but not big enough to cause problems.
    • This includes storing the result & doing c_kzg_free before doing asserts.
  • Fix commitments issue in one of the profiler functions.

To fix the broken test, please merge #474 first.

Copy link
Contributor

@asn-d6 asn-d6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@asn-d6 asn-d6 merged commit 002537d into ethereum:main Aug 8, 2024
38 checks passed
@jtraglia jtraglia deleted the improve-tests-and-analyze branch August 8, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants