Fixed NixOs vendoring issue #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @akorchyn thanks for taking this on! Looks good, just need to update the CI workflow. |
|
Sorry, I missed one spot in the build.rs :) |
ralexstokes
reviewed
Mar 12, 2024
jtraglia
approved these changes
Mar 15, 2024
There was a problem hiding this comment.
LGTM 🥇thanks again @akorchyn! Just want some confirmations from the team before merging.
- @ralexstokes could you confirm that this fixes your issue?
- @Rjected & @pawanjay176 will this still work with Reth & Lighthouse?
pawanjay176
approved these changes
Mar 15, 2024
Rjected
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #392
You can test it by