Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to publish python package #395

Merged
merged 7 commits into from
Mar 4, 2024

Conversation

jtraglia
Copy link
Member

This PR adds a new workflow which publishes the python module to PyPI.

Marking this as a draft until devops has added the API key to GitHub secrets.

@kclowes (from EF snake charmers team) requested this.

@jtraglia
Copy link
Member Author

Okay, the API key should be in the repo's secrets now. Ready for review.

@jtraglia jtraglia marked this pull request as ready for review February 26, 2024 15:21
@jtraglia
Copy link
Member Author

Hmm I'm going to convert this to use ciwheelhouse which should simplify things a bit.

Copy link

@kclowes kclowes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me @jtraglia. Thank you! I'm getting a deprecation warning from using python3 setup.py install here, but I did verify it's working! When I swapped that line locally with python -m build (the newer syntax), I was getting a clang error and haven't had time to debug. I can dig in more on Monday if you want, but it's just a deprecation warning so I think this is good to merge as-is. /cc @fselmo

@jtraglia
Copy link
Member Author

jtraglia commented Mar 1, 2024

Hey @kclowes, thanks for the review! I think I'm okay with a deprecation warning.

I'll plan to merge this on Monday & make a new release to test it soon after.

@asn-d6 asn-d6 merged commit f9abc5f into ethereum:main Mar 4, 2024
35 checks passed
@jtraglia jtraglia deleted the python-pip-package branch March 4, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants