New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make standalone portable feature, enabled by default #391

Merged

jtraglia merged 1 commit into ethereum:main from Rjected:add-portable-feature-2

Feb 7, 2024

Contributor

Rjected commented Feb 6, 2024

This way crates can do:

c-kzg = { version = "0.4.x", default-features = false }

[features]
default = ["portable"]
std = ["c-kzg/std"] # common pattern w/ std
portable = ["c-kzg/portable"]

instead of

c-kzg = { version = "0.4.1", default-features = false }
blst = { version = "0.3.11", default-features = false, optional = true }

[features]
default = ["portable"]
std = ["c-kzg/std"] # common pattern w/ std
portable = ["dep:blst", "blst?/portable"]


          chore: make standalone portable feature, enabled by default

fcca119

jtraglia approved these changes

View reviewed changes

Member

jtraglia left a comment

LGTM 👍

jtraglia merged commit 0bbeded into ethereum:main

35 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet