Set /std:c11 ccflag for Windows in Rust bindings #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
This was referenced Aug 31, 2023
Closed
Merged
|
@jtraglia @asn-d6 I think this is not a correct fix and causing issues when the toolchain is set to GNU https://stackoverflow.com/questions/58226545/how-to-switch-between-rust-toolchains GCC compiler is complaining that https://rust-lang.github.io/rustup/installation/windows.html |
ghost
mentioned this pull request
1 task
|
Hey @kaliubuntu0206 👋 I'm okay with only setting it for MSVC, sounds like a mistake on my part. Would you like to make a PR for this? Also worth noting, blst appears to have fixed this problem (supranational/blst@9c87d4a). I don't think we should update blst right now though, since we would prefer to use a stable release. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes our Windows issues. This is an alternative to #353.
See #353 for details about the problem. To be brief, if
__STDC_VERSION__isn't defined as c99 or greater, blst will typedef a bool as an int (this check is here btw). There is a bug in bindgen associated with this. MSVC doesn't define__STDC_VERSION__by default, but we can use the/stdflag to set it toc11, which is the earliest version it supports.Fixes #318.
Fixes #331.
Big thanks to @pawanjay176 & @michaelsproul for identifying this.