This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Optimize SELFDESTRUCT opcode in aleth-interpreter #5806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5806 +/- ##
=========================================
Coverage ? 64.08%
=========================================
Files ? 359
Lines ? 30783
Branches ? 3418
=========================================
Hits ? 19726
Misses ? 9827
Partials ? 1230 |
halfalicious
changed the title
|
Here's the same optimization in LegacyVM: #5807 |
halfalicious
changed the title
halfalicious
force-pushed
the
selfdestruct-optimizations-01
branch
from
492f636
to
e7cb213
Compare
gumb0
reviewed
Nov 4, 2019
halfalicious
force-pushed
the
selfdestruct-optimizations-01
branch
from
e7cb213
to
d5789d2
Compare
gumb0
approved these changes
Nov 5, 2019
added 2 commits
November 5, 2019 09:07
Optimization avoids state accesses if tx doesn't include enough gas to cover base selfdestruct fee
halfalicious
force-pushed
the
selfdestruct-optimizations-01
branch
from
a1913d9
to
39b6f21
Compare
|
Rebased + squashed commits |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5767
Optimization avoids state accesses if tx doesn't include enough gas to
cover base selfdestruct fee. Verified that all EVMOne tests pass.