This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Replace optimizer-special opcodes with 0xaf instead of INVALID. #5680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way when PUSHC/JUMPC/JUMPCI are encountered in input code, EVMC_UNDEFINED_INSTRUCTION will be returned and not EVMC_INVALID_INSTRUCTION.
Codecov Report
@@ Coverage Diff @@
## master #5680 +/- ##
==========================================
+ Coverage 63.03% 63.05% +0.02%
==========================================
Files 350 350
Lines 29952 29952
Branches 3352 3352
==========================================
+ Hits 18880 18887 +7
+ Misses 9856 9851 -5
+ Partials 1216 1214 -2 |
chfast
approved these changes
Jul 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5666 fix.
Fixes the problem described in #5653 (comment) - allows
EVMC_UNDEFINED_INSTRUCTIONto be returned whenPUSHC/JUMPC/JUMPCIare encountered in input code.