This repository has been archived by the owner on Oct 28, 2021. It is now read-only.
Shift opcodes #4569
Closed
Shift opcodes #4569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@axic @chfast It appears we have been working independently on these opcodes here and in #4054, and that we have come up with different implementations. So one or the other of these should be merged, but not both. If I don't hear from you today perhaps we can discuss it after the staff meeting tomorrow. |
|
Mostly redundant with #4054, differences to be kept should be merged there. |
chfast
reviewed
Oct 3, 2017
| { | ||
| uint64_t amount = uint64_t(m_SP[0]); | ||
| m_SPP[0] = shiftee >> amount; | ||
| m_SPP[0] |= allbits << (256 - amount); |
There was a problem hiding this comment.
I think you have to check shiftee & hibit here as well.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SHL and SHR are well tested by test/unittests/performance/rc5.sol. SAR is only lightly tested.
The
#define EIP_145 truein VMConfig.h will need to be turned off once all tests pass here.