-
Notifications
You must be signed in to change notification settings - Fork 36
Adopt go.work, rename modules to prep for monorepo #414
Conversation
b216411
to
7329233
Compare
Stuck on a go issue:
Which I think causes a build issue which the linting tooling can't handle (but go itself can somehow...):
|
See btcsuite/btcd#1839 |
f762ce0
to
1cd9f16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this looks good. The big thing I'd like is to set a cutoff date for which PRs go in first and which PRs should be built on top of this branch (to try to limit merge / rebase conflicts).
Rebased to resolve merge conflicts. Edit: and force-pushed again to fix the |
Deleted code cov comment since it wasn't updating anymore. Coverage is stable, no changes to actual code, and we merge all the coverage reports of different modules by pushing them all to codecov. You can find the coverage diff here: https://app.codecov.io/gh/ethereum-optimism/optimistic-specs/compare/main...go-work (some renames, basically 0 coverage difference) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some small comments around the makefile.
Also FYI - the integration test didn't pass locally, but I think that is probably the test being flaky b/c it passed in CI.
@@ -18,9 +18,17 @@ submodules: | |||
fi | |||
.PHONY: submodules | |||
|
|||
opnode: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not here, but in submodules, we very likely want --recursive
. Maybe this changes with the new contracts stuff, but foundry-lib seemed to need it.
@@ -35,39 +43,34 @@ clean: | |||
.PHONY: clean |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The clean command doesn't do anything b/c we leave binaries in the subdirectory
@@ -4,7 +4,7 @@ ITESTS_L2_HOST=http://localhost:9545 | |||
build: build-go contracts integration-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not this, but above COMPOSEFLAGS
/ITESTS_L2_HOST
doesn't seem to be referenced anywhere. (
I can help fix this merge conflict with a rebase in 4 hours from now. Basically need to rebase on |
This PR:
op-node
,op-proposer
,op-batcher
,op-e2e
ops
toops-bedrock
, to prepare for monorepo