Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

triedb/pathdb: support v0 journal format #368

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

protolambda
Copy link
Collaborator

@protolambda protolambda commented Aug 21, 2024

Description

Very experimental draft to handle v0 of the geth pathdb journal, load it, and try to work with it in the case where all storage-diffs are complete, which should be compatible with journal v1.

Tests

Tested on devnet to go from 1.13 to 1.14 geth datadir by @sebastianst

Metadata

Fix #360

Copy link
Member

@sebastianst sebastianst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good pragmatic approach to me, to drop the journal only if it actually contains legacy Incomplete markers, but accept it otherwise. Thanks!

triedb/pathdb/journal.go Outdated Show resolved Hide resolved
triedb/pathdb/journal.go Outdated Show resolved Hide resolved
@protolambda protolambda marked this pull request as ready for review August 22, 2024 17:53
@protolambda protolambda requested a review from a team as a code owner August 22, 2024 17:53
@sebastianst sebastianst merged commit 5c2e758 into optimism Aug 22, 2024
10 checks passed
@sebastianst sebastianst deleted the v0-journal-support branch August 22, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Database corruption during restarts since switching to upstream v1.14.7
2 participants