Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add redis_url to StateRedisStorage to allow initialization by URL #2041

Merged
merged 1 commit into from
Sep 10, 2023
Merged

Add redis_url to StateRedisStorage to allow initialization by URL #2041

merged 1 commit into from
Sep 10, 2023

Conversation

Cub11k
Copy link
Contributor

@Cub11k Cub11k commented Sep 8, 2023

Description

Useful for rediss:// and unix:// schemes

Describe your tests

How did you test your change?

Python version:

OS:

Checklist:

  • I added/edited example on new feature/change (if exists)
  • My changes won't break backward compatibility
  • I made changes both for sync and async

Badiboy
Badiboy approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@Badiboy Badiboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for me.

@Badiboy Badiboy mentioned this pull request Sep 8, 2023
Closed
3 tasks
@coder2020official
Copy link
Collaborator

LGTM, thanks

@coder2020official coder2020official merged commit aef5727 into eternnoir:master Sep 10, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Badiboy Badiboy Badiboy approved these changes

@coder2020official coder2020official coder2020official approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cub11k @coder2020official @Badiboy