Remove the outdated gif screenshot and refine the behavior of auth #446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gyuho if you have recommendation for gif screenshot (font and size for terminal emulator, etc), I'll take a new one. But it won't be consistent with the existing screenshots so I just deleted the outdated one. |
spzala
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outdated documentation related to auth was reported in etcd-io/etcd#12966
This PR fixes the issue. It removes the screenshot gif and enhance the command line description.
The behavior of the root role was fixed in etcd-io/etcd#6355 , the root can access to every key so it doesn't cause permission errors described in the current doc.