-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/health reports unhealthy when alarm is raised #8272
Conversation
Can this detect when etcd is in maintenance mode / has an alarm raised instead of exposing quota stuff? That way it'll be able to handle corruption alarms too... |
@heyitsanthony PTAL. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thanks
etcdserver/server.go
Outdated
@@ -1667,3 +1667,7 @@ func (s *EtcdServer) goAttach(f func()) { | |||
f() | |||
}() | |||
} | |||
|
|||
func (s *EtcdServer) ListAlarms() []*pb.AlarmMember { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alarms()
?
Signed-off-by: Gyu-Ho Lee <gyuhox@gmail.com>
Fix #8207.