Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to create WAL files #18605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucasrod16
Copy link
Contributor

Relates to #18574 (comment)

This PR adds a new function to consolidate WAL file creation into a single function to help reduce errors and make the process more consistent.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lucasrod16
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @lucasrod16. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 68.84%. Comparing base (9fc3b2a) to head (081c94f).

Current head 081c94f differs from pull request most recent head d0cd63a

Please upload reports for the commit d0cd63a to get more accurate results.

Files with missing lines Patch % Lines
server/storage/wal/wal.go 71.42% 2 Missing and 2 partials ⚠️
server/storage/wal/file_pipeline.go 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
Files with missing lines Coverage Δ
server/storage/wal/repair.go 56.14% <100.00%> (ø)
server/storage/wal/file_pipeline.go 90.69% <0.00%> (ø)
server/storage/wal/wal.go 57.73% <71.42%> (+0.27%) ⬆️

... and 18 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18605      +/-   ##
==========================================
+ Coverage   68.79%   68.84%   +0.04%     
==========================================
  Files         420      420              
  Lines       35519    35532      +13     
==========================================
+ Hits        24437    24461      +24     
+ Misses       9655     9644      -11     
  Partials     1427     1427              

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc3b2a...d0cd63a. Read the comment docs.

@lucasrod16 lucasrod16 force-pushed the use-single-function-to-create-WAL-files branch from 1d57f5d to c2852b2 Compare September 19, 2024 17:56
Signed-off-by: Lucas Rodriguez <lucas.rodriguez9616@gmail.com>
@lucasrod16 lucasrod16 force-pushed the use-single-function-to-create-WAL-files branch from c2852b2 to d0cd63a Compare September 19, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants