Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Fix govulncheck CI check #18170

Merged

Conversation

henrybear327
Copy link
Contributor

@henrybear327 henrybear327 commented Jun 13, 2024

This commit fixed the Go Vulnerability Checker CI job, which isn't scanning for all go.mod files within the project.

Reference:

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@henrybear327
Copy link
Contributor Author

/cc @ivanvc @ahrtr @serathius

@henrybear327
Copy link
Contributor Author

Follow up on #17703

@henrybear327 henrybear327 force-pushed the ci/fix_govulncheck_release_3.5 branch 2 times, most recently from 1ca4d4b to 9952090 Compare June 13, 2024 20:28
@henrybear327 henrybear327 force-pushed the ci/fix_govulncheck_release_3.5 branch 2 times, most recently from d5d3645 to 644b234 Compare June 14, 2024 09:31
This commit fixed the Go Vulnerability Checker CI job, which isn't
scanning for all go.mod files within the project.

Reference:
- etcd-io#18168

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
Extracted log from govulncheck, suggesting that we should bump the
version of golang.org/x/net

=== Symbol Results ===

Vulnerability #1: GO-2024-2687
    HTTP/2 CONTINUATION flood in net/http
  More info: https://pkg.go.dev/vuln/GO-2024-2687
  Module: golang.org/x/net
    Found in: golang.org/x/net@v0.17.0
    Fixed in: golang.org/x/net@v0.23.0

Reference:
- etcd-io#17708

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
…ab57 to v0.0.0-20220412211240-33da011f77ad

Extracted log from govulncheck, suggesting that we should bump the
version of golang.org/x/sys

Vulnerability #1: GO-2022-0493
    Incorrect privilege reporting in syscall and golang.org/x/sys/unix
  More info: https://pkg.go.dev/vuln/GO-2022-0493
  Module: golang.org/x/sys
    Found in: golang.org/x/sys@v0.0.0-20210403161142-5e06dd20ab57
    Fixed in: golang.org/x/sys@v0.0.0-20220412211240-33da011f77ad

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327 henrybear327 force-pushed the ci/fix_govulncheck_release_3.5 branch from 644b234 to e72a799 Compare June 14, 2024 09:33
@henrybear327 henrybear327 requested a review from ivanvc June 14, 2024 09:36
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Please also update 3.5 changelog

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @henrybear327

henrybear327 added a commit to henrybear327/etcd that referenced this pull request Jun 14, 2024
Fully address CVE-2023-45288 and fix govulncheck CI check

Reference:
- etcd-io#18170

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@henrybear327
Copy link
Contributor Author

Update release-3.5 changelog #18178

#18178

Done as requested! :)

@ahrtr ahrtr merged commit 6267a12 into etcd-io:release-3.5 Jun 14, 2024
25 checks passed
@henrybear327 henrybear327 deleted the ci/fix_govulncheck_release_3.5 branch June 14, 2024 20:39
@ivanvc ivanvc mentioned this pull request Jun 28, 2024
4 tasks
@jmhbnz
Copy link
Member

jmhbnz commented Jun 28, 2024

/retitle [3.5] Fix govulncheck CI check

@k8s-ci-robot k8s-ci-robot changed the title Fix govulncheck CI check on release-3.5 [3.5] Fix govulncheck CI check Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants