Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script and workflow to detect flaky tests in testgrid. #17662

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

siyuanfoundation
Copy link
Contributor

@siyuanfoundation siyuanfoundation commented Mar 27, 2024

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

For #13167

Ideally this should live in the k8s test-infra or testgrid repo for it to be maintained long term. But that is a much bigger and longer effort that requires coordination with the sig-testing team.

For now, I think it is beneficial to get it running while we seek long term solution with the sig-testing team.

Example of auto created issue: siyuanfoundation#10

@siyuanfoundation
Copy link
Contributor Author

cc @serathius @jmhbnz @ahrtr

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO, the result is looking great 👏
I left a couple of suggestions, and I hope it's ok ✌️

tools/testgrid-analysis/cmd/github.go Outdated Show resolved Hide resolved
tools/testgrid-analysis/go.mod Outdated Show resolved Hide resolved
tools/testgrid-analysis/cmd/data.go Outdated Show resolved Hide resolved
Signed-off-by: Siyuan Zhang <sizhang@google.com>
Signed-off-by: Siyuan Zhang <sizhang@google.com>
@siyuanfoundation
Copy link
Contributor Author

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for addressing my comments

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great first iteration - thanks @siyuanfoundation

@ahrtr ahrtr merged commit 0168c3e into etcd-io:main Apr 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants