*: fix revive linter #16634
Merged
*: fix revive linter #16634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Remove old revive_pass in the bash scripts and migirate the revive.toml into golangci linter_settings. Signed-off-by: Wei Fu <fuweid89@gmail.com>
ahrtr
reviewed
Sep 25, 2023
| @@ -315,7 +314,7 @@ type MaybeEtcdResponse struct { | |||
| Error string | |||
| } | |||
|
|
|||
| var EtcdFutureRevErr = errors.New("future rev") | |||
| var ErrEtcdFutureRev = errors.New("future rev") | |||
There was a problem hiding this comment.
Did revive linter raise a warning on this?
There was a problem hiding this comment.
Yeah.
The error is here
deterministic.go:318:5: error-naming: error var EtcdFutureRevErr should have name of the form ErrFoo (revive)
var EtcdFutureRevErr = errors.New("future rev")
^
| @@ -421,7 +421,7 @@ func (tb triggerBlackhole) Available(config e2e.EtcdProcessClusterConfig, proces | |||
| return config.ClusterSize > 1 && process.PeerProxy() != nil | |||
| } | |||
|
|
|||
| func blackhole(t *testing.T, ctx context.Context, member e2e.EtcdProcess, clus *e2e.EtcdProcessCluster, shouldWaitTillSnapshot bool) error { | |||
| func blackhole(ctx context.Context, t *testing.T, member e2e.EtcdProcess, clus *e2e.EtcdProcessCluster, shouldWaitTillSnapshot bool) error { | |||
There was a problem hiding this comment.
Did revive linter raise a warning on this?
There was a problem hiding this comment.
Yes
failpoints.go:424:30: context-as-argument: context.Context should be the first parameter of a function (revive)
func blackhole(t *testing.T, ctx context.Context, member e2e.EtcdProcess, clus *e2e.EtcdProcessCluster, shouldWaitTillSnapshot bool) error {
| - name: context-keys-type | ||
| severity: error | ||
| disabled: false | ||
| # TODO: enable the following rules |
There was a problem hiding this comment.
I mean why they are disabled now and when to enable them?
It isn't a big deal though.
There was a problem hiding this comment.
@ahrtr The TODO was defined in the tests/revive.toml. I can file issue to track this~
serathius
approved these changes
Sep 25, 2023
ahrtr
approved these changes
Sep 25, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old revive_pass in the bash scripts and migirate the revive.toml into golangci linter_settings.
Part of #16610
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.