Add example format for initial-cluster in configuration file #15938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
May 23, 2023
jmhbnz
force-pushed
the
clarify-initial-cluster
branch
2 times, most recently
from
68c041e
to
1446753
Compare
ahrtr
approved these changes
May 23, 2023
serathius
approved these changes
May 23, 2023
Signed-off-by: James Blair <mail@jamesblair.net>
jmhbnz
force-pushed
the
clarify-initial-cluster
branch
from
1446753
to
b2ee988
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In discussion #15837 an etcd user wasn't clear about how to specify
initial-clusterin the configuration file which led to their cluster not starting, and unfortunately our sample configuration file currently doesn't provide any real guidance on this.Let's help our users get it right the first time by adding a quick example format to the config file.
Longer term we should also investigate better handling of spaces in these strings so a more expressive dictionary style could be freely used as well.