Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate auth test to common #4 #15351

Merged
merged 1 commit into from
Feb 26, 2023
Merged

Conversation

chaochn47
Copy link
Member

Related to the ask from #14041 to split tests into smaller pieces.

So code review will be reviewer friendly and easier to reason about.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Signed-off-by: Chao Chen <chaochn@amazon.com>
@chaochn47 chaochn47 changed the title migrate to auth test #4 migrate auth test to common #4 Feb 23, 2023
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @chaochn47

@serathius serathius merged commit cb2a22e into etcd-io:main Feb 26, 2023
@chaochn47 chaochn47 deleted the auth_test_split_4 branch February 27, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants