Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move inactive maintainers to emeritus #14373

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

serathius
Copy link
Member

I'm proposing to remove inactive maintainers based on new process established in #14238.

In addition I will be sending an email to maintainers mailing list that will cc removed maintainers, to ensure they are notified.

This PR requires approval of two other maintainers. To allow affected maintainers time to object I will leave 3 weeks of lazy consensus on this PR.

cc @ptabor @ahrtr @spzala @gyuho @mitake @jingyih @jpbetz @hexfusion @wenjiaswe @xiang90 @bdarnell @tbg

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @serathius for driving this.

Just to reiterate that the any EMERITUS maintainer can easily regain the maintainer role once starting to contribute to the project again.

@codecov-commenter
Copy link

Codecov Report

Merging #14373 (0785ef4) into main (192d635) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #14373      +/-   ##
==========================================
- Coverage   71.02%   70.71%   -0.31%     
==========================================
  Files         455      455              
  Lines       37146    37146              
==========================================
- Hits        26384    26269     -115     
- Misses       9266     9365      +99     
- Partials     1496     1512      +16     
Flag Coverage Δ
all 70.71% <ø> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/etcdserver/api/v3rpc/util.go 51.61% <0.00%> (-16.13%) ⬇️
server/proxy/grpcproxy/register.go 69.76% <0.00%> (-9.31%) ⬇️
server/storage/mvcc/watchable_store.go 84.42% <0.00%> (-9.06%) ⬇️
server/auth/simple_token.go 80.00% <0.00%> (-8.47%) ⬇️
client/pkg/v3/fileutil/purge.go 66.03% <0.00%> (-7.55%) ⬇️
client/v3/leasing/util.go 91.66% <0.00%> (-6.67%) ⬇️
client/v3/concurrency/session.go 88.63% <0.00%> (-4.55%) ⬇️
client/pkg/v3/testutil/leak.go 62.83% <0.00%> (-4.43%) ⬇️
server/etcdserver/api/v3rpc/interceptor.go 73.43% <0.00%> (-4.17%) ⬇️
server/etcdserver/txn/util.go 75.47% <0.00%> (-3.78%) ⬇️
... and 20 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ptabor ptabor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM.

I'm just curious why not to keep the history of maintainenceship in the MAINTAINERS file,
such that e.g. option to be moved to MAINTAINERS is more obvious.

@serathius
Copy link
Member Author

Over 2 weeks passed and most of the maintainers have acked the change in etcd-maintainers email group. With that I don't think there is a need to delay the change any more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants