-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move inactive maintainers to emeritus #14373
Conversation
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @serathius for driving this.
Just to reiterate that the any EMERITUS maintainer can easily regain the maintainer role once starting to contribute to the project again.
Codecov Report
@@ Coverage Diff @@
## main #14373 +/- ##
==========================================
- Coverage 71.02% 70.71% -0.31%
==========================================
Files 455 455
Lines 37146 37146
==========================================
- Hits 26384 26269 -115
- Misses 9266 9365 +99
- Partials 1496 1512 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM.
I'm just curious why not to keep the history of maintainenceship in the MAINTAINERS file,
such that e.g. option to be moved to MAINTAINERS is more obvious.
Over 2 weeks passed and most of the maintainers have acked the change in etcd-maintainers email group. With that I don't think there is a need to delay the change any more. |
I'm proposing to remove inactive maintainers based on new process established in #14238.
In addition I will be sending an email to maintainers mailing list that will cc removed maintainers, to ensure they are notified.
This PR requires approval of two other maintainers. To allow affected maintainers time to object I will leave 3 weeks of lazy consensus on this PR.
cc @ptabor @ahrtr @spzala @gyuho @mitake @jingyih @jpbetz @hexfusion @wenjiaswe @xiang90 @bdarnell @tbg