Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue with the loop after writing to ctrlStream #11778

Closed
wants to merge 1 commit into from

Conversation

tedyu
Copy link
Contributor

@tedyu tedyu commented Apr 11, 2020

#11754 fixed a bug where watch stream was prematurely closed.

However, when the write to sws.ctrlStream succeeds, we should continue with the for loop. The existing code doesn't achieve this purpose.

This PR makes the continue effective by introducing label.

/cc @polyrabbit @xiang90 @jingyih

Signed-off-by: Ted Yu <yuzhihong@gmail.com>
@tedyu tedyu closed this Apr 11, 2020
@polyrabbit
Copy link
Contributor

I suppose the continue itself is enough to continue with the for loop

case sws.ctrlStream <- wr:
continue
case <-sws.closec:
return nil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants