Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ctlv3: add newline in EndpointHealth output #10788

Merged
merged 1 commit into from
Jun 5, 2019

Conversation

jingyih
Copy link
Contributor

@jingyih jingyih commented Jun 4, 2019

Add back the newline character in output of EndpointHealth, so that the output message is consistent with the output message before #9540.

cc @gyuho

To make the output consistent with the output before etcd-io#9540.
@jingyih
Copy link
Contributor Author

jingyih commented Jun 4, 2019

Once merged, will backport to previous release branches.

@xiang90
Copy link
Contributor

xiang90 commented Jun 4, 2019

lgtm

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@gyuho gyuho merged commit ea45cd6 into etcd-io:master Jun 5, 2019
gyuho added a commit that referenced this pull request Jun 5, 2019
…8-origin-release-3.3

Automated cherry pick of #10788 on release-3.3
gyuho added a commit that referenced this pull request Jun 5, 2019
…8-origin-release-3.2

Automated cherry pick of #10788 on release-3.2
gyuho added a commit that referenced this pull request Jun 5, 2019
…8-origin-release-3.1

Automated cherry pick of #10788 on release-3.1
@jingyih jingyih deleted the add_missing_newline_EndpointHealth branch September 7, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants