*: fix broken import paths in proto files #10739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that 9150bf5 of etcd-io#10640 broke import paths of proto files. Because of this scripts/genproto.sh causes errors on the latest master branch. This commit fixes the broken paths.
|
Hmm it breaks the build process itself because the go files generated from proto have different paths, which don't have module version (see travis). @gyuho do you have any ideas for making genproto and go mod related update coexisting well? If we cannot specify import paths in generated go files from proto, and go module versioning is not emergent, I think the changes introduced in #10640 should be reverted for now. |
|
Does anyone has any idea? @etcd-io/maintainers-etcd |
|
lgtm thanks! |
|
@mitake Can we remove the changes in |
|
Nvm. The doc is autogenerated. |
|
Closing in favor of #10766. |
|
@gyuho thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that 9150bf5 of #10640
broke import paths of proto files. Because of this scripts/genproto.sh
causes errors on the latest master branch. This commit fixes the
broken paths.